[Webkit-unassigned] [Bug 103704] [EFL][WK2] Implement Accelerated2DCanvas on WK2 Efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103704





--- Comment #31 from Kyungjin Kim <gen.kim at samsung.com>  2012-12-04 17:38:40 PST ---
(In reply to comment #30)
> (In reply to comment #29)
> > (In reply to comment #28)
> > > (In reply to comment #27)
> > > > (In reply to comment #26)
> > > > > (In reply to comment #23)
> > > > > > Created an attachment (id=177414)
 --> (https://bugs.webkit.org/attachment.cgi?id=177414&action=review) [details] [details] [details] [details] [details] [details]
> > 
> > > > canvasHasGraphicsSurface should always return true when GRAPHICS_SURFACE is >used. TRUE is default, returning false is exceptional case so if no canvas >layer exists true should be returned because it means no exceptional case. >You feel me?
> > > 
> > > k, it is bit confusing that we return true even in case GRAPHICS_SURFACE is not used (in case GraphicsLayer doesn't have a valid platformLayer).
> > 
> > why is the return value of  canvasHasGraphicsSurface () dependent on m_canvasPlatformLayer?? 

if m_canvasPlatformlayer is null, it means there's no canvas layer for 2D here so the return value should be dependent on it.
> > 
> > Actually, would it be better to query this from platformlayer itself rather than having it in graphicslayer??
> 
> I mean would it be better to query from platformLayer, if it is using a graphicssurface or not, rather than doing it in coordinatedgraphicslayer

It was. I checked it in Canvas2DLayerEfl originally. But it's been changed by Noam's suggestion. Do you believe checking it in each platformLayer could be better?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.