[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implemented color chooser proxy and input picker interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91832





--- Comment #54 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-08-20 08:09:33 PST ---
(In reply to comment #53)
> As I know, there are three kinds of input type. One is file, another is color and the other is date and time related. These types are handled differently in webkit. File type is using file chooser(openPanel), color type is using color chooser(has own proxy) and the others are handled as text field.
> 
> So, I think, it's required three kinds of api; the api for file input type, the api for color input type and the api for other types. This patch is one of these apis for color input type.

Could we make it only do that then? and file bugs for the others?

> Date and time picker can be implemented by 1 api which is set the value. But color picker has 2 apis. One is set the value and the other is close the color chooser. It's allowed to call set api multiple times before close the color chooser. I think it's a difference between EFL and QT.

Why shouldn't that be possible for a date? Shouldn't it have select and close as well? I think it should.

> Why I am not make it as WK2 C api is because I'm not sure it's required for all ports. I'm working on EFL port and it's required, so I just implemented it for EFL. Actually, it's been implemented for Tizen first. I think it can be contributed, so I uploaded this patch.

I am pretty sure that Qt and GTK would like this as well, it would be cool if you could give it a try

> As you mentioned, file picker, color picker and the date and time picker is most what we need for now. File picker and date and time picker should be implemented for EFL soon.
> 
> Rest of the types in ewk_view.h like tel, number, email, etc are for the reserved use. These values can be used by application, in the future. I may remove these values for now, and add again when these values are used.

I think you should remove them for now, they can be handled in the future.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.