[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implemented color chooser proxy and input picker interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91832





--- Comment #55 from KwangYong Choi <ky0.choi at samsung.com>  2012-08-20 18:31:52 PST ---
(In reply to comment #54)
> (In reply to comment #53)
> > As I know, there are three kinds of input type. One is file, another is color and the other is date and time related. These types are handled differently in webkit. File type is using file chooser(openPanel), color type is using color chooser(has own proxy) and the others are handled as text field.
> > 
> > So, I think, it's required three kinds of api; the api for file input type, the api for color input type and the api for other types. This patch is one of these apis for color input type.
> 
> Could we make it only do that then? and file bugs for the others?

I think it's possible to file bugs for the others in the future. The features are separately implemented on Tizen.

> > Date and time picker can be implemented by 1 api which is set the value. But color picker has 2 apis. One is set the value and the other is close the color chooser. It's allowed to call set api multiple times before close the color chooser. I think it's a difference between EFL and QT.
> 
> Why shouldn't that be possible for a date? Shouldn't it have select and close as well? I think it should.

You're right. It can be possible. I just think about local implementation. In case of date and time picker, only one api which is set the value is implemented. I think, it's possible to implement for color type as well.

Do you think only one api which is set the value is required for all input pickers? I designed input_picker_show/input_picker_hide function can be used for all input types, but not for the set apis. Is it better to provide one api for the all types?

> > Why I am not make it as WK2 C api is because I'm not sure it's required for all ports. I'm working on EFL port and it's required, so I just implemented it for EFL. Actually, it's been implemented for Tizen first. I think it can be contributed, so I uploaded this patch.
> 
> I am pretty sure that Qt and GTK would like this as well, it would be cool if you could give it a try

Well, at first, I want just to implement color chooser proxy for EFL. For now, apis are added and a test is included. This patch is larger and larger. And it takes long time.

I wish WK2 C api could be handled by separate bug.

> > As you mentioned, file picker, color picker and the date and time picker is most what we need for now. File picker and date and time picker should be implemented for EFL soon.
> > 
> > Rest of the types in ewk_view.h like tel, number, email, etc are for the reserved use. These values can be used by application, in the future. I may remove these values for now, and add again when these values are used.
> 
> I think you should remove them for now, they can be handled in the future.

OK. You're right. I remove them for now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.