[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implemented color chooser proxy and input picker interface

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 19 07:18:08 PDT 2012


--- Comment #47 from Thiago Marcos P. Santos <tmpsantos at gmail.com>  2012-08-19 07:18:38 PST ---
(In reply to comment #46)
> (In reply to comment #44)
> > (In reply to comment #42)
> > > >> Christophe has a patch that adds click support to the utest framework. I added it as dependency of this bug.
> > > 
> > > It looks this patch can simulate user gesture as Bug 90454. But, I'd like to recommend to support this test in new bug because of review convenience. KwangYoung, could you file a bug for this patch's unit test ?
> > 
> > tmpsantos can confirm but I believe he prefers that the unit tests lands in the same patch and the feature. This avoids forgetting about the utests later and the functionality is tested as soon as it lands and we know it works for sure when it lands.
> If we link a bug for unit test to this bug, we can remember to add unit test. IIRC, did you add unit tests in new bug ? In addition, I think review thread in this bug is already long. But, if KwangYong want to add unit test to this patch, I don't mind.

When developers adds new features to WebCore, they have to write layout tests at the same patch. With EFL API, we should do the same. The only exception would be if, before landing this patch, the bug for the utests has a patch with r+. That was my case when I was writing ColorPicker for Qt and the reason I did that was because the test was QML and had to be reviewed by a QML expert.

New EFL features without tests should not be accepted anymore. We have a pretty decent test framework, bots are running the tests for every commit, documentation about how to write tests, etc.

Untested features are a nightmare when things start to fail, you are completely clueless about where to start looking. EFL WK2 is new, we have unique opportunity to have an API with 100% of test coverage.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list