[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implemented color chooser proxy and input picker interface

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 19 06:55:42 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=91832





--- Comment #46 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-08-19 06:56:15 PST ---
(In reply to comment #44)
> (In reply to comment #42)
> > >> Christophe has a patch that adds click support to the utest framework. I added it as dependency of this bug.
> > 
> > It looks this patch can simulate user gesture as Bug 90454. But, I'd like to recommend to support this test in new bug because of review convenience. KwangYoung, could you file a bug for this patch's unit test ?
> 
> tmpsantos can confirm but I believe he prefers that the unit tests lands in the same patch and the feature. This avoids forgetting about the utests later and the functionality is tested as soon as it lands and we know it works for sure when it lands.

If we link a bug for unit test to this bug, we can remember to add unit test. IIRC, did you add unit tests in new bug ? In addition, I think review thread in this bug is already long. But, if KwangYong want to add unit test to this patch, I don't mind.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list