[Webkit-unassigned] [Bug 83007] [EFL] EFL's LayoutTestController overridePreference implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83007





--- Comment #5 from Dominik Röttsches <dominik.rottsches at linux.intel.com>  2012-04-11 07:24:48 PST ---
(In reply to comment #3)
> (From update of attachment 136650 [details])
> The ewk_view_setting_{get,set}() stuff isn't very EFL-like, and is yet another place to maintain when adding/removing settings. I don't like this. 
> 
> One could easily write LayoutTestController::overridePreference() by calling directly the already existing ewk_view_setting family of functions, without sacrificing readability at the call site.
> 
> Informal r-.

Mikhail's approach has been up for discussion before this patch was submitted, pls compare: https://lists.webkit.org/pipermail/webkit-efl/2012-April/000158.html 
Feedback there had been rather positive.

As you say, it is or becomes a "family" of functions, but a large one, given that there would be about 8 more functions to be added at least.

Could you reconsider your r-? It may not be 100% EFL style, but IMHO it's an improvement over adding more individual functions.

So, in a next step, the existing family of functions would be migrated to this approach.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.