[webkit-efl] ewk_view settings implementation

Pozdnyakov, Mikhail mikhail.pozdnyakov at intel.com
Tue Apr 3 04:21:35 PDT 2012


 I am implementing now LayoutTestController::overridePreference method for EFL

I've noticed that each ewk_view related setting (web preference) is currently present in ewk_view as a separate function (see functions starting with ewk_view_setting_... )

In order to implement LayoutTestController::overridePreference I will need to add more ewk_view_setting_ functions to the ewk_view (as not all the settings are present there). That will affect the existing API and
will look quite ugly.

 Don't you think it would be better to have two common methods (getter and setter) for all the web preferences like :

Eina_Bool  ewk_view_setting_set(Evas_Object *o,  const char* property,  const Eina_Value* value );
Eina_Bool ewk_view_setting_get(const Evas_Object *o,  const char* property,  Eina_Value* value );

I could do such refactoring  within the  bug83007.

Could  you  please tell  your opinion about my proposal?


Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

More information about the webkit-efl mailing list