[Webkit-unassigned] [Bug 83007] [EFL] EFL's LayoutTestController overridePreference implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83007





--- Comment #4 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com>  2012-04-11 07:10:34 PST ---
(In reply to comment #3)
> (From update of attachment 136650 [details])
> The ewk_view_setting_{get,set}() stuff isn't very EFL-like, and is yet another place to maintain when adding/removing settings. I don't like this. 
> 
> One could easily write LayoutTestController::overridePreference() by calling directly the already existing ewk_view_setting family of functions, without sacrificing readability at the call site.
> 
> Informal r-.

Not all the necessary settings are currently present in ewk_view_setting family. 
Keeping the old approach would require adding of 6 new functions to the ewk_view interface (for 3 new settings). Solving of https://bugs.webkit.org/show_bug.cgi?id=83687 will also require adding of 2 more functions and so on.. 
Isn't it better to have a common setter/getter interface for all the settings?
The whole old ewk_view_setting family could be removed and it would significantly  decrease the size of ewk_view header file and improve its readability.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.