[Webkit-unassigned] [Bug 44505] [EFL] Missing plugins support for efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44505





--- Comment #49 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-09-20 08:09:44 PST ---
(From update of attachment 107993)
View in context: https://bugs.webkit.org/attachment.cgi?id=107993&action=review

> Source/WebCore/CMakeListsEfl.txt:7
> +  "${DERIVED_SOURCES_DIR}"

I'd rather if this patch just added plugins/efl to the list.

> Source/WebCore/plugins/efl/PluginViewEfl.cpp:187
> +    FILE* fileHandle = fopen(filename.utf8().data(), "r");

Besides getFileSize, you could also use openFile, readFromFile and the other calls from FileSystem.h.

> Source/WebCore/plugins/efl/PluginViewEfl.cpp:340
> +{

Missing notImplemented().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.