[Webkit-unassigned] [Bug 44505] [EFL] Missing plugins support for efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44505





--- Comment #50 from Mariusz Grzegorczyk <mariusz.g at samsung.com>  2011-09-20 08:30:40 PST ---
(In reply to comment #48)
> (From update of attachment 107993 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107993&action=review
> 
> Informal r- for the reason below.
> 
> > Source/WebCore/plugins/efl/PluginViewEfl.cpp:181
> > +    if (filename.startsWith("file:///"))
> > +#if defined(XP_UNIX)
> > +        filename = filename.substring(7);
> > +#else
> > +        filename = filename.substring(8);
> > +#endif
> 
> If you're on Unix, a "file:///bin/bash" URI will have the "file://" stripped, yielding "/bin/bash". This is correct. However, I don't understand why the first '/' is stripped in a non-Unix build, since only "file://" is part of the URI schema. For example: "file://c:/autoexec.bat" will be transformed to ":/autoexec.bat", which is clearly wrong.

At first the if statement says that this is only in case that filename starts with "file:///", so there is no problem with example: "file://c:/autoexec.bat". Second: as I know proper uri schema for local file is "file:///", for other combinations like: "file://something" it will try to resolve name "something" f.e. file://localhost/.... For windows proper schema for local file will be f.e. "file:///C:/autoexec.bat". Same stripping is made in Mac, Qt and Win ports, however I think it should be fixed at least in Qt.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.