[Webkit-unassigned] [Bug 44505] [EFL] Missing plugins support for efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44505


Leandro Pereira <leandro at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107993|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #48 from Leandro Pereira <leandro at profusion.mobi>  2011-09-20 08:04:43 PST ---
(From update of attachment 107993)
View in context: https://bugs.webkit.org/attachment.cgi?id=107993&action=review

Informal r- for the reason below.

> Source/WebCore/plugins/efl/PluginViewEfl.cpp:181
> +    if (filename.startsWith("file:///"))
> +#if defined(XP_UNIX)
> +        filename = filename.substring(7);
> +#else
> +        filename = filename.substring(8);
> +#endif

If you're on Unix, a "file:///bin/bash" URI will have the "file://" stripped, yielding "/bin/bash". This is correct. However, I don't understand why the first '/' is stripped in a non-Unix build, since only "file://" is part of the URI schema. For example: "file://c:/autoexec.bat" will be transformed to ":/autoexec.bat", which is clearly wrong.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.