[Webkit-unassigned] [Bug 68206] Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68206





--- Comment #7 from Xianzhu Wang <wangxianzhu at chromium.org>  2011-09-19 19:16:14 PST ---
(From update of attachment 107629)
View in context: https://bugs.webkit.org/attachment.cgi?id=107629&action=review

>> Source/WebKit/chromium/WebKit.gyp:1265
>> +                'public',
> 
> Is this include only needed for Chromium{CurrentTime,Threading}.cpp?  If so, maybe it should be in the condition below?

tests/RunAllTests.cpp also needs it.

>> Source/WebKit/chromium/WebKit.gyp:1270
>> +                ''
> 
> Nit: Remove this blank line

Will change it.

>> Source/WebKit/chromium/WebKit.gyp:1276
>> +                        'src/ChromiumThreading.cpp',
> 
> In the shared_library build on windows, do we call currentTime() or ChromiumThreading::callOnMainThread()?  Should we include separate stub implementations when linking TestWebKitAPI rather than using the definitions in webkit?  For example, we could add stubs in WebKit/Tools/TestWebKitAPI/chromium/.

I reused the tests/RunAllTests.cpp which uses webkit_support. As webkit_support is the testing support of Chromium, I think it's reasonable for TestWebKitAPI on Chromium to reuse the same facility, and also reuse other stuffs of Chromium WebKit as much as possible. What's your opinion?

>> Tools/TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:32
>> +#include <wtf/Vector.h>
> 
> I don't understand this include/ForwardingHeader change.  Can you describe why this is needed in the ChangeLog?  Why does it work in the Apple Mac build?

Originally in Apple Mac the code uses #include <JavaScriptCore/...> to include WTF headers in a magic way (I don't know the details of how it works). However, the path <JavaScriptCore/Vector.h> doesn't exist on some other platforms, so we should change it to <wtf/Vector.h>, but because Mac still expects <JavaScriptCore/Vector.h>, to resolve this problem, each header that is included in <wtf/...> way should have a forwarding header file to include <JavaScriptCore/...>.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.