[Webkit-unassigned] [Bug 68206] Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68206


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107629|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #6 from Tony Chang <tony at chromium.org>  2011-09-19 18:51:31 PST ---
(From update of attachment 107629)
View in context: https://bugs.webkit.org/attachment.cgi?id=107629&action=review

> Is it intended that component=shared_library doesn't work for 'build-wekit --chromium'?

We don't have a bot for this, so I'm not surprised it doesn't work.

I don't really understand exactly how TestWebKitAPI works on win/mac and I don't have access to a win/mac right now.  I'll look again tomorrow.

> Source/WebKit/chromium/WebKit.gyp:1265
> +                'public',

Is this include only needed for Chromium{CurrentTime,Threading}.cpp?  If so, maybe it should be in the condition below?

> Source/WebKit/chromium/WebKit.gyp:1270
> +                ''

Nit: Remove this blank line

> Source/WebKit/chromium/WebKit.gyp:1276
> +                        'src/ChromiumCurrentTime.cpp',
> +                        'src/ChromiumThreading.cpp',

In the shared_library build on windows, do we call currentTime() or ChromiumThreading::callOnMainThread()?  Should we include separate stub implementations when linking TestWebKitAPI rather than using the definitions in webkit?  For example, we could add stubs in WebKit/Tools/TestWebKitAPI/chromium/.

> Tools/TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:32
> -#include <JavaScriptCore/MetaAllocator.h>
> -#include <JavaScriptCore/Vector.h>
> +#include <stdarg.h>
> +#include <wtf/MetaAllocator.h>
> +#include <wtf/Vector.h>

I don't understand this include/ForwardingHeader change.  Can you describe why this is needed in the ChangeLog?  Why does it work in the Apple Mac build?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.