[Webkit-unassigned] [Bug 68206] Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68206





--- Comment #8 from Tony Chang <tony at chromium.org>  2011-09-20 11:16:40 PST ---
(From update of attachment 107629)
View in context: https://bugs.webkit.org/attachment.cgi?id=107629&action=review

>>> Source/WebKit/chromium/WebKit.gyp:1276

>> 
>> In the shared_library build on windows, do we call currentTime() or ChromiumThreading::callOnMainThread()?  Should we include separate stub implementations when linking TestWebKitAPI rather than using the definitions in webkit?  For example, we could add stubs in WebKit/Tools/TestWebKitAPI/chromium/.
> 
> I reused the tests/RunAllTests.cpp which uses webkit_support. As webkit_support is the testing support of Chromium, I think it's reasonable for TestWebKitAPI on Chromium to reuse the same facility, and also reuse other stuffs of Chromium WebKit as much as possible. What's your opinion?

On further inspection, this seems fine.  I was a confused by how this works in the shared_library case, but have convinced myself that this is OK.  Please add a comment here explaining why this is needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.