[Webkit-unassigned] [Bug 64733] Forms with display:none on the submit button do not get submitted on enter
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 5 13:24:45 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=64733
Ryosuke Niwa <rniwa at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #106322|review? |review-
Flag| |
--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org> 2011-09-05 13:24:44 PST ---
(From update of attachment 106322)
View in context: https://bugs.webkit.org/attachment.cgi?id=106322&action=review
r- due to various nits.
> Source/WebCore/ChangeLog:4
> + on enter.
Nit: it seems like "on enter" can hit on the previous line.
> Source/WebCore/ChangeLog:9
> + Removed check for render() on submit button. Even if submit button has
Nit: s/render/renderer/
> LayoutTests/fast/forms/hidden-submit-button-form-action.html:3
> + <script>
Nit: I don't think we normally indent script element or the actual script like this.
> LayoutTests/fast/forms/hidden-submit-button-form-action.html:18
> +<body onload="test()">
Do we really need to wait until the page is loaded? Can't we just put script element below the form element and call submit?
> LayoutTests/fast/forms/hidden-submit-button-form-action.html:19
> + <form onsubmit="log('Test Passed'); return false;">
Nit: We normally just print "PASS" instead of "Test Passed".
> LayoutTests/fast/forms/hidden-submit-button-form-action.html:21
> + <input id="txtbox1"/>
Nit: Please don't use abbreviations such as txt.
> LayoutTests/fast/forms/hidden-submit-button-form-action.html:22
> + <input id="txtbox2"/>
Nit: Why do we need to have two input elements?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list