[Webkit-unassigned] [Bug 64733] Forms with display:none on the submit button do not get submitted on enter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64733





--- Comment #8 from Kaustubh Atrawalkar <kaustubh at motorola.com>  2011-09-05 23:18:28 PST ---
Hi Alexy, 
Adding to Ryosuke's comments, this check for renderer() is only to check if the submit button is displayed or not. The earlier check if (formElement->isSuccessfulSubmitButton()) does check if the submit button is there or not. There might be cases where user just want to show the form with submit action but dont want to show typical submit button. In that case the he can add a button with display:none which will destroy its renderer. And he wont be able to submit form. Removing this check will support as per the bug requirement.

Also from the specs http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#implicit-submission
on the last line it says - "If the form has no submit button, then the implicit submission mechanism must just submit the form element from the form element itself."

(In reply to comment #6)
> (In reply to comment #5)
> > Kaustubh, could you please follow the history of the renderer check in svn to see why it was added? The check certainly looks like it's intentional, not "extra".
> 
> Two changesets touched that line:
> http://trac.webkit.org/changeset/59173
> http://trac.webkit.org/changeset/5367
> 
> And the latter is the one that introduced renderer check.  As far as I can tell the check was introduced because the the code started calling element->renderer()->absolutePosition(x,y); and static_cast<QButton *>(static_cast<RenderWidget *>(element->renderer())->widget())->simulateClick();
> 
> But given that the test passes, dispatchSimulatedClick doesn't appear to be dependent on renderer at this point.  So I'd say this fix is correct.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.