[Webkit-unassigned] [Bug 64733] Forms with display:none on the submit button do not get submitted on enter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64733


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |darin at apple.com
     Ever Confirmed|0                           |1




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2011-09-05 13:19:42 PST ---
(In reply to comment #5)
> Kaustubh, could you please follow the history of the renderer check in svn to see why it was added? The check certainly looks like it's intentional, not "extra".

Two changesets touched that line:
http://trac.webkit.org/changeset/59173
http://trac.webkit.org/changeset/5367

And the latter is the one that introduced renderer check.  As far as I can tell the check was introduced because the the code started calling element->renderer()->absolutePosition(x,y); and static_cast<QButton *>(static_cast<RenderWidget *>(element->renderer())->widget())->simulateClick();

But given that the test passes, dispatchSimulatedClick doesn't appear to be dependent on renderer at this point.  So I'd say this fix is correct.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.