[Webkit-unassigned] [Bug 19079] Send the submissions character encoding in hidden _charset_ field

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19079





--- Comment #5 from Vineet Chaudhary (vineetc) <rgf748 at motorola.com>  2011-11-02 04:41:32 PST ---
(In reply to comment #4)
> (From update of attachment 113138 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113138&action=review
> 
> > Source/WebCore/loader/FormSubmission.cpp:188
> > +            if (equalIgnoringCase(input->name(), "_charset_") && input->isInputTypeHidden())
> > +                    input->setValueForUser(domFormData->encoding().name());
> 

> * I don't think we should update HTMLInputELement::value.  How does IE work?
Even IE also modifies the value of input field.

> * It's dangerous to use setValueForUser(), which dispatches an event and execute JavaScript code, which might update the associated element list.
> * According to the specification, we should set the character encoding only if the hidden input has no value attribute.
I tested with IE, Mozilla and Opera behavior, but none of them respect "value" if inputType is hidden, they all sets respective encoding types here.
Please let me know if we want different behavior from these.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.