[Webkit-unassigned] [Bug 19079] Send the submissions character encoding in hidden _charset_ field

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19079


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113138|review?                     |review-
               Flag|                            |




--- Comment #4 from Kent Tamura <tkent at chromium.org>  2011-11-01 22:15:20 PST ---
(From update of attachment 113138)
View in context: https://bugs.webkit.org/attachment.cgi?id=113138&action=review

> Source/WebCore/loader/FormSubmission.cpp:188
> +            if (equalIgnoringCase(input->name(), "_charset_") && input->isInputTypeHidden())
> +                    input->setValueForUser(domFormData->encoding().name());

* Wrong indentation
* According to the specification, we should set the character encoding only if the hidden input has no value attribute.
* I don't think we should update HTMLInputELement::value.  How does IE work?
* It's dangerous to use setValueForUser(), which dispatches an event and execute JavaScript code, which might update the associated element list.

> LayoutTests/ChangeLog:14
> +        * http/tests/misc/char_encoding_in_hidden_charset_field_01-expected.txt: Added.
> +        * http/tests/misc/char_encoding_in_hidden_charset_field_01.html: Added. For Default Encoding.

We usually use '-' to concatenate words, not '_'.

Please assign meaningful names instead of numbers.  e.g. char_encoding_in_hidden_charset_field_02.html should be char-encoding-in-hidden-charset-field-with-accept-charset.html

We should have tests for Chinese/Japanese encodings such as Big5, Shift_JIS, EUC-JP, ISO-2022-JP.  This feature is important in these countries.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.