[Webkit-unassigned] [Bug 19079] Send the submissions character encoding in hidden _charset_ field

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19079





--- Comment #6 from Kent Tamura <tkent at chromium.org>  2011-11-02 06:23:23 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 113138 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=113138&action=review
> > 
> > > Source/WebCore/loader/FormSubmission.cpp:188
> > > +            if (equalIgnoringCase(input->name(), "_charset_") && input->isInputTypeHidden())
> > > +                    input->setValueForUser(domFormData->encoding().name());
> > 
> 
> > * I don't think we should update HTMLInputELement::value.  How does IE work?
> Even IE also modifies the value of input field.

Please investigate the behavior of other browsers correctly.
I have just checked the behavior of IE9, Firefox 7, and Opera 11.51. All of them didn't care about the existence of value attribute, and didn't update HTMLInputElement::value.
We can check this behavior by a simple HTML like the following, and inspect the form.

<form action="..." target="_blank">
<input type=hidden name=_charset_ value=foo>
<input type=submit>
</form>


> > * According to the specification, we should set the character encoding only if the hidden input has no value attribute.
> I tested with IE, Mozilla and Opera behavior, but none of them respect "value" if inputType is hidden, they all sets respective encoding types here.
> Please let me know if we want different behavior from these.

We should update the specification first.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.