[Webkit-unassigned] [Bug 56043] Leaks Viewer should present a list of recent builds to analyze

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 14 14:49:55 PDT 2011


--- Comment #4 from Adam Roben (:aroben) <aroben at apple.com>  2011-03-14 14:49:56 PST ---
(From update of attachment 85721)
View in context: https://bugs.webkit.org/attachment.cgi?id=85721&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:123
>> +        loader.start("SnowLeopard Intel Leaks", this._numberOfRecentBuildsToLoad);
> Nit: I guess this is okay to hard-code.  Eventually, we may want another way to pick from a list of bots?

Yeah, eventually. Right now we only have one of course.

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:192
>> +            recentBuildsContainer.appendChild(document.createTextNode("No recent leaky builds found"));
> Nit:  Should say:  "No recent leaky builds found.  Go home."  (At least consider adding a period to the existing message. :)

Added a period.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list