[Webkit-unassigned] [Bug 56043] Leaks Viewer should present a list of recent builds to analyze

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56043


David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85721|review?                     |review+
               Flag|                            |




--- Comment #3 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2011-03-14 14:47:22 PST ---
(From update of attachment 85721)
View in context: https://bugs.webkit.org/attachment.cgi?id=85721&action=review

r=me

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:123
> +        loader.start("SnowLeopard Intel Leaks", this._numberOfRecentBuildsToLoad);

Nit: I guess this is okay to hard-code.  Eventually, we may want another way to pick from a list of bots?

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:192
> +            recentBuildsContainer.appendChild(document.createTextNode("No recent leaky builds found"));

Nit:  Should say:  "No recent leaky builds found.  Go home."  (At least consider adding a period to the existing message. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.