[Webkit-unassigned] [Bug 56043] Leaks Viewer should present a list of recent builds to analyze

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56043


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85721|review+                     |review?
               Flag|                            |




--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org>  2011-03-14 14:50:19 PST ---
(From update of attachment 85721)
View in context: https://bugs.webkit.org/attachment.cgi?id=85721&action=review

Some general js comments. Nice coding style!

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:178
> +                link.href = document.location.href + "?url=" + build.url;

I think this should window.encodeURIComponent(build.url)

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:33
> +        url += range(maximumNumberOfBuilds).map(function(n) { return "select=-" + (n + 1); }).join("&");

Maybe even here too (inside the map function), but this seems harmless.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:57
> +                            buildInfo.leakCount = match[1];

Nit: optional, parseInt(match[1], 10) since it looks like you want this to be a numerical value.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.