[Webkit-unassigned] [Bug 62430] <progress> should support :indeterminate pseudo-class

Sun Jun 12 19:08:54 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=62430

--- Comment #10 from Dominic Cooney <dominicc at chromium.org>  2011-06-12 19:08:54 PST ---
(From update of attachment 96903)
View in context: https://bugs.webkit.org/attachment.cgi?id=96903&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:1085
> +            if ((thisProgressElement->isDeterminate() && !otherProgressElement->isDeterminate()) || (!thisProgressElement->isDeterminate() && otherProgressElement->isDeterminate()))

Maybe

thisProgressElement->isDeterminate() != otherProgressElement->isDeterminate()

is simpler?

Then since there is only one expression, you could inline the casts to shorten this a bit more.

> LayoutTests/fast/dom/HTMLProgressElement/indeterminate-progress-001.html:1
> +<!DOCTYPE html>

Does the pixel result for this test really add anything that the textual result doesn't have?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.