[Webkit-unassigned] [Bug 62430] <progress> should support :indeterminate pseudo-class

Mon Jun 13 06:33:17 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=62430


--- Comment #11 from Yael <yael.aharon at nokia.com>  2011-06-13 06:33:16 PST ---
(In reply to comment #10)
> (From update of attachment 96903 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96903&action=review
Thank you for reviewing :)
> 
> > Source/WebCore/css/CSSStyleSelector.cpp:1085
> > +            if ((thisProgressElement->isDeterminate() && !otherProgressElement->isDeterminate()) || (!thisProgressElement->isDeterminate() && otherProgressElement->isDeterminate()))
> 
> Maybe
> 
> thisProgressElement->isDeterminate() != otherProgressElement->isDeterminate()
> 
> is simpler?
> 
ok

> Then since there is only one expression, you could inline the casts to shorten this a bit more.
> 
> > LayoutTests/fast/dom/HTMLProgressElement/indeterminate-progress-001.html:1
> > +<!DOCTYPE html>
> 
> Does the pixel result for this test really add anything that the textual result doesn't have?
I think so; Just like progress-bar-value-pseudo-element.html, the pixel result shows that we can see the changes to the style of the progress element.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.