[Webkit-unassigned] [Bug 62430] <progress> should support :indeterminate pseudo-class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62430





--- Comment #9 from Kent Tamura <tkent at chromium.org>  2011-06-12 19:06:14 PST ---
(From update of attachment 96903)
View in context: https://bugs.webkit.org/attachment.cgi?id=96903&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:1078
>      if (isControl) {

nit: This block for isControl is large.  Can we make a separated function?

> Source/WebCore/html/HTMLProgressElement.cpp:140
> +    return (HTMLProgressElement::IndeterminatePosition != position() && HTMLProgressElement::InvalidPosition != position());

Calling position() twice is not efficient.

> LayoutTests/fast/dom/HTMLProgressElement/indeterminate-progress-001.html:12
> +  document.getElementById("dymanicindeterminate").removeAttribute("value");
> +  document.getElementById("dymanicdeterminate").setAttribute("value", 0.5);
> +}

We usually use 4-space indentation in JavaScript code.

> LayoutTests/fast/dom/HTMLProgressElement/indeterminate-progress-002.html:10
> +window.onload = function() {
> +  if (window.layoutTestController)

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.