[Webkit-unassigned] [Bug 62149] Web Inspector: [Chromium] DevTools does not highlight elements when accelerated compositing is on.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62149





--- Comment #10 from Vangelis Kokkevis <vangelis at chromium.org>  2011-06-10 14:34:40 PST ---
(From update of attachment 96253)
View in context: https://bugs.webkit.org/attachment.cgi?id=96253&action=review

Looks good overall to me (minus the one comment).  James can you please have a look too?

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:286
> +    m_webViewImpl->setPageOverlayClient(this);

highlight seems like a method that will get called often.  setPageOverlayClient() seems to blindly create a new PageOverlay instance.  Isn't that excessive?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.