[Webkit-unassigned] [Bug 62149] Web Inspector: [Chromium] DevTools does not highlight elements when accelerated compositing is on.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62149





--- Comment #9 from Vsevolod Vlasov <vsevik at chromium.org>  2011-06-07 10:03:11 PST ---
I have uploaded a new patch with the GraphicsLayer approach. Since there is no way to get GraphicsLayer from LayerChromium, I changed ChromeClientImpl to pass root GraphicsLayer to WebViewImpl, where I save it and use for overlay manipulations.

(In reply to comment #4)
> (From update of attachment 96124 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96124&action=review
> 
> > Source/WebKit/chromium/src/PageOverlay.cpp:84
> > +    if (!m_viewImpl->isAcceleratedCompositingActive()) {
> 
> isAcceleratedCompositingActive() needs to be protected by USE(ACCELERATED_COMPOSITING) guards.
I don't think it needs that, I made it the same way I saw in WebViewImpl, (e.g. WebViewImpl::resize)

> > Source/WebKit/chromium/src/PageOverlay.cpp:105
> > +void PageOverlay::webFramePainted(GraphicsContext& gc)
> 
> The method should probably be named using an active verb.  paintWebFrame ?
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.