[Webkit-unassigned] [Bug 62149] Web Inspector: [Chromium] DevTools does not highlight elements when accelerated compositing is on.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62149


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96253|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #11 from James Robinson <jamesr at chromium.org>  2011-06-10 14:53:15 PST ---
(From update of attachment 96253)
View in context: https://bugs.webkit.org/attachment.cgi?id=96253&action=review

This is looking great overall.  My main concern is the same as Vangelis' - it seems that this code will create a new PageOverlay on every call to highlightNode(), which is super frequent.  Can you look into that?

> Source/WebKit/chromium/src/PageOverlay.cpp:57
> +    update();

is this call just to run the code at lines 129-132?  can you just move that cleanup code directly to here? i realize that probably means adding an #if USE(ACCELERATED_COMPOSITING) block here but that feels less weird than calling a member function inside a destructor

> Source/WebKit/chromium/src/PageOverlay.h:60
> +    PageOverlay(WebViewImpl*, PageOverlayClient*);
> +    WebViewImpl* m_viewImpl;

super-nitpicky nitpick: would prefer a newline between the last member function and the first member variable, just to make this a bit easier to scan

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.