[Webkit-unassigned] [Bug 61865] [Qt] Implement download feature for QtTestBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61865





--- Comment #6 from Andras Becsi <abecsi at webkit.org>  2011-06-03 06:46:14 PST ---
(From update of attachment 95867)
View in context: https://bugs.webkit.org/attachment.cgi?id=95867&action=review

Later this could be extended with a simple progress bar, but I think this is not the scope of this patch.

Because of the problems previously pointed out, I would say r- for this patch if I were a reviewer.

> Tools/QtTestBrowser/launcherwindow.cpp:992
> +        QMessageBox::warning(this, QString("Download"), QString("Download failed."));

Further more, the message shown here could be more expressive if you would display m_reply->errorString(). And I would use critical here, but that's only a nitpick.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.