[Webkit-unassigned] [Bug 61865] [Qt] Implement download feature for QtTestBrowser

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 3 07:43:05 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61865


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95867|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #7 from Csaba Osztrogonac <ossy at webkit.org>  2011-06-03 07:43:05 PST ---
(From update of attachment 95867)
I agree with Andras, user shouldn't get "Download failed" error if he or she 
pressed cancel button. And crital message would be better than warning message.
r- now, but I'll set r+ if you fix these things.

> Tools/QtTestBrowser/launcherwindow.cpp:991
> +    if (fileName.isEmpty() && m_reply->error() != QNetworkReply::NoError)

I mean this would be good:

if (fileName.isEmpty())
    return;
if (m_reply->error() != QNetworkReply::NoError)
    QMessageBox::critical(this, QString("Download"), QString("Download failed."));

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list