[Webkit-unassigned] [Bug 61865] [Qt] Implement download feature for QtTestBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61865





--- Comment #5 from Andras Becsi <abecsi at webkit.org>  2011-06-03 06:30:28 PST ---
(In reply to comment #4)
> (From update of attachment 95867 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95867&action=review
> 
> > Tools/QtTestBrowser/launcherwindow.cpp:991
> > +    if (fileName.isEmpty() && m_reply->error() != QNetworkReply::NoError)
> 
> AND does not seem to be correct here, you need OR.

Most probably if you have fileName.isEmpty() then you sould simply return, since the user pressed "Cancel" on the dialog, and only show an error message when m_reply->error() indicates an error.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.