[Webkit-unassigned] [Bug 26755] webkit-patch's commit messages are less readable than commit-log-editor's

Thu Jul 7 15:56:28 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=26755

--- Comment #49 from Adam Barth <abarth at webkit.org>  2011-07-07 15:56:28 PST ---
> Where is this documented?

It's not document.

> How is it enforced (other than patch reviews)?

It's enforced by patch reviews.

> Where would one go to learn about this?

By writing patches for webkitpy and learning by interacting with reviewers.

> Does one need to read the entire webkitpy (test) codebase to soak up this knowledge?

How does one soak up knowledge about other parts of the codebase?  We generally ask that folks be active contributors to an area of code before reviewing patches in that area.

> Will do.  But I think it should be a goal of WebKit to make it easy to write tests (whether they're layout tests, webkitpy tests or webkitperl tests) so that more people can contribute without investing the better part of a day studying existing code for "subtle invariants" or requiring that one of only a handful of people review the patches.

That's what the review process is for.  The error is very easy to spot for folks who review and write code in this area often.  It's also easy to fix once spotted.  What's problematic is for folks to review patches in areas that they don't understand throughly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.