[Webkit-unassigned] [Bug 26755] webkit-patch's commit messages are less readable than commit-log-editor's

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26755





--- Comment #50 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2011-07-08 08:23:02 PST ---
(In reply to comment #49)
> > Will do.  But I think it should be a goal of WebKit to make it easy to write tests (whether they're layout tests, webkitpy tests or webkitperl tests) so that more people can contribute without investing the better part of a day studying existing code for "subtle invariants" or requiring that one of only a handful of people review the patches.
> 
> That's what the review process is for.  The error is very easy to spot for folks who review and write code in this area often.  It's also easy to fix once spotted.  What's problematic is for folks to review patches in areas that they don't understand throughly.

I think it would also be beneficial if these "subtle invariants" could be made more explicit through either assertions (assuming Python has such a mechanism; maybe throwing exceptions?) or changes in the structure of the code to make it much harder to write incorrect code (which is likely harder in an interpreted scripting language than C++, but maybe still possible?).

Such changes would also decrease the amount of time it takes to explain these concepts when someone wants to contribute to the tools, since new tests would break immediately in a working copy if they violated the invariants.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.