[Webkit-unassigned] [Bug 26755] webkit-patch's commit messages are less readable than commit-log-editor's

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26755





--- Comment #48 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2011-07-07 15:34:02 PST ---
(In reply to comment #32)
> @ddkilzer: This patch contains a couple architectural mistakes.  For example, grabbing the executive statically rather than using the dependency injection layer is a subtle but important violation of an invariant that we try to maintain across the entire codebase.

Where is this documented?  How is it enforced (other than patch reviews)?  Where would one go to learn about this?  Does one need to read the entire webkitpy (test) codebase to soak up this knowledge?

> In the future, it might be better to give someone who works on webkitpy frequently a chance to look at a patch before landing it.

Will do.  But I think it should be a goal of WebKit to make it easy to write tests (whether they're layout tests, webkitpy tests or webkitperl tests) so that more people can contribute without investing the better part of a day studying existing code for "subtle invariants" or requiring that one of only a handful of people review the patches.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.