[Webkit-unassigned] [Bug 51155] [GTK] Menulist text often collides with separator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51155





--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-01-21 03:56:11 PST ---
(From update of attachment 79610)
View in context: https://bugs.webkit.org/attachment.cgi?id=79610&action=review

> Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:411
> +    // Menu list button painting strategy.
> +    // For buttons with appears-as-list set to false (having a separator):
> +    // | left border | Button text | xthickness | vseparator | xthickness | arrow | xthickness | right border |
> +    // For buttons with appears-as-list set to true (not having a separator):
> +    // | left border | Button text | arrow | xthickness | right border |
> +

This is not correct actually, it's not only a matter of showing a separator or not, appears-as-list has more implications. The main one is that the drop down list is not a menu, but a tree view, and the widgets to show the button are not the same. When appears-as-list is set, there's a frame, that might have a different bg color than a button depending on the theme, and a small button with the arrow, while when appears-as-list is not set the whole widget is a toggle button that contains an hbox with the separator and the arrow. I think we can just ignore this style property, since we are not going to show the same result than gtk+ and, even more important, the drop down will always be a menu in our case. 
See current implementations of the combo box depending on appears-as-list style property:
http://git.gnome.org/browse/gtk+/tree/gtk/gtkcombobox.c#n3246
http://git.gnome.org/browse/gtk+/tree/gtk/gtkcombobox.c#n2940

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.