[Webkit-unassigned] [Bug 51155] [GTK] Menulist text often collides with separator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51155


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79610|review?                     |review+
               Flag|                            |




--- Comment #11 from Xan Lopez <xan.lopez at gmail.com>  2011-01-21 03:23:21 PST ---
(From update of attachment 79610)
View in context: https://bugs.webkit.org/attachment.cgi?id=79610&action=review

Looks reasonable to me. r=me

> Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:335
> +    static GtkBorder defaultInnerBorder = {1, 1, 1, 1};

Hrm, is making this static useful/needed? It could be const, on the other hand.

> Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:365
> +        getComboBoxSeparatorWidth() + (3 * buttonWidgetStyle->xthickness);

Hrm, so where does the 3 come from?

> Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:408
> +    // | left border | Button text | xthickness | vseparator | xthickness | arrow | xthickness | right border |

Oh, I guess the 3 comes from here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.