[Webkit-unassigned] [Bug 51155] [GTK] Menulist text often collides with separator

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 21 12:15:27 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=51155





--- Comment #13 from Martin Robinson <mrobinson at webkit.org>  2011-01-21 12:15:27 PST ---
(In reply to comment #11)

Thanks for the review!

> > Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:335
> > +    static GtkBorder defaultInnerBorder = {1, 1, 1, 1};
>
> Hrm, is making this static useful/needed? It could be const, on the other hand.

I'll change this.

> > Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:365
> > +        getComboBoxSeparatorWidth() + (3 * buttonWidgetStyle->xthickness);
> 
> Hrm, so where does the 3 come from?

I'll leave a comment here referring to the one below.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list