[Webkit-unassigned] [Bug 51312] Make ContextShadow code cross-platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51312





--- Comment #11 from Dirk Schulze <krit at webkit.org>  2011-01-17 09:58:07 PST ---
(In reply to comment #10)
> (From update of attachment 79112 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79112&action=review
> 
> I'm tempted to r+ this, though the public variables in ContextShadow lead to a r-. Who allowed this to be landed? :-)
> 
> > Source/WebCore/platform/graphics/ContextShadow.h:82
> > +    ContextShadowType m_type;
> >  
> >      Color m_color;
> > -    int m_blurDistance;
> > +    IntSize m_blurDistance;
> >      FloatSize m_offset;
> 
> public variables?
> This needs to be hidden....

I thought the same :-) But Simon already opened another bug for cleaning up ContextShadow. It was not my intention to clean up ContextShadow in the first place.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.