[Webkit-unassigned] [Bug 51312] Make ContextShadow code cross-platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51312


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79112|review?                     |review-
               Flag|                            |




--- Comment #10 from Nikolas Zimmermann <zimmermann at kde.org>  2011-01-17 08:09:00 PST ---
(From update of attachment 79112)
View in context: https://bugs.webkit.org/attachment.cgi?id=79112&action=review

I'm tempted to r+ this, though the public variables in ContextShadow lead to a r-. Who allowed this to be landed? :-)

> Source/WebCore/platform/graphics/ContextShadow.h:82
> +    ContextShadowType m_type;
>  
>      Color m_color;
> -    int m_blurDistance;
> +    IntSize m_blurDistance;
>      FloatSize m_offset;

public variables?
This needs to be hidden....

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.