[Webkit-unassigned] [Bug 51312] Make ContextShadow code cross-platform

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 17 10:17:36 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=51312





--- Comment #12 from Ariya Hidayat <ariya.hidayat at gmail.com>  2011-01-17 10:17:35 PST ---
> I'm tempted to r+ this, though the public variables in ContextShadow lead to a r-. Who allowed this to be landed? :-)
> 
> > Source/WebCore/platform/graphics/ContextShadow.h:82
> > +    ContextShadowType m_type;
> >  
> >      Color m_color;
> > -    int m_blurDistance;
> > +    IntSize m_blurDistance;
> >      FloatSize m_offset;
> 
> public variables?
> This needs to be hidden....

Because it was a private, lightweight helper struct for Qt port only. Then it got adopted by everyone.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list