[Webkit-unassigned] [Bug 54893] Remove CorrectionIndicator markers sooner.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54893





--- Comment #11 from jpu at apple.com  2011-02-28 15:14:25 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > > In fact, we can probably make the isEmpty check an assertion if we make sure to clear the types any time we empty out the markers. We’re probably already really close to that.
> > 
> > Not sure we can do this. Since possiblyHasMarkers() only check on specified marker types. m_markers can still be non-empty when possiblyHasMarkers() returns false.
> 
> I think you got my suggestion backwards. The assertion would be this:
> 
>     if (!possiblyHasMarkers(markerTypes))
>         return;
>     ASSERT(!m_markers.isEmpty());
> 
> Would there be some case where that would not work?

Ah, then we will have to do:

 if (!possiblyHasMarkers(DocumentMarker::AllTypes))
         return;
  ASSERT(!m_markers.isEmpty());

Then we will need to check again in functions that are only interested in particular types:
if (!possiblyHasMarkers(markerTypes))
         return;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.