[Webkit-unassigned] [Bug 54893] Remove CorrectionIndicator markers sooner.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54893


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84124|review?                     |review+
               Flag|                            |




--- Comment #10 from Darin Adler <darin at apple.com>  2011-02-28 14:53:53 PST ---
(From update of attachment 84124)
View in context: https://bugs.webkit.org/attachment.cgi?id=84124&action=review

> Source/WebCore/dom/DocumentMarkerController.cpp:585
> +inline bool DocumentMarkerController::possiblyHasMarkers(DocumentMarker::MarkerTypes types)
> +{
> +    return m_possiblyExistingMarkerTypes & types;
> +}

Because this is an inline, I think we might need it to be at the top of the file, before any callers. Not sure. I think the EWS bot may tell us if I’m right.

> Source/WebCore/dom/DocumentMarkerController.h:86
> +    MarkerMap m_markers;
> +    // Provide a quick way to determine whether a particular marker type is absent without going through the map.
> +    DocumentMarker::MarkerTypes m_possiblyExistingMarkerTypes;
> +    bool possiblyHasMarkers(DocumentMarker::MarkerTypes);

Normally we put the data members in a separate paragraph after all the function members.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.