[Webkit-unassigned] [Bug 54893] Remove CorrectionIndicator markers sooner.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 28 15:22:09 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=54893





--- Comment #12 from Darin Adler <darin at apple.com>  2011-02-28 15:22:09 PST ---
(In reply to comment #11)
> Ah, then we will have to do:
> 
>  if (!possiblyHasMarkers(DocumentMarker::AllTypes))
>          return;
>   ASSERT(!m_markers.isEmpty());
> 
> Then we will need to check again in functions that are only interested in particular types:
> if (!possiblyHasMarkers(markerTypes))
>      return;

No we wouldn’t. My original code would work fine:

    if (!possiblyHasMarkers(markerTypes))
        return;
    ASSERT(!m_markers.isEmpty());

If it possibly has a marker of any one type, then it has at least one marker. If ever got down to zero markers we would have zeroed out the entire marker type mask.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list