[Webkit-unassigned] [Bug 73430] [EFL] Add pre-rendering implementation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73430


Tomasz Morawski <t.morawski at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.morawski at samsung.com




--- Comment #16 from Tomasz Morawski <t.morawski at samsung.com>  2011-12-23 02:27:33 PST ---
Few small comments:

> Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1881
> +    const int maxViewSideLength = std::max(viewSlicer.col2 - viewSlicer.col1 , viewSlicer.row2 - viewSlicer.row1);

Codint style: ' ,'. And line below this same. 

> Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1892
> +        for (int i = 1; i < step * squareSide + 1; i++) {

"step * squareSide + 1" this could be moved outside the loop.

> Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1919
> +            if (static_cast<int>(viewSlicer.col1) < centerColumn

It may look better when these static_cast operations will be done once before this two ifs

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.