[Webkit-unassigned] [Bug 73430] [EFL] Add pre-rendering implementation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73430





--- Comment #15 from JungJik Lee <jungjik.lee at samsung.com>  2011-12-23 02:12:17 PST ---
(In reply to comment #14)
> (From update of attachment 120430 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120430&action=review
> 
> > Source/WebKit/efl/ewk/ewk_view_tiled.cpp:236
> > +static inline void _ewk_view_tiled_rect_collision_resolve(int direction, int* destinationX, int* destinationY, int destinationWidth, int destinationHeight, int sourceX, int sourceY, int sourceWidth, int sourceHeight)
> 
> IMO, how about using IntRect or Eina_Rectangle for internal functions ?
> 
> IntRect is better for me.
> 
IntRect is big for this, I will change it with using Eina_Rectangle.

> > Source/WebKit/efl/ewk/ewk_view_tiled.cpp:239
> > +        *destinationX = *destinationX + (sourceX - *destinationX);
> 
> I don't know what you want, but it looks strange.
> *destinationX will be sourceX.
> 
> In addition 1, 2, 4, 8 can be enumaration.

I totally agree that it means nothing. I will change them again!
Enumeration is considerable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.