[Webkit-unassigned] [Bug 73430] [EFL] Add pre-rendering implementation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73430





--- Comment #17 from JungJik Lee <jungjik.lee at samsung.com>  2011-12-23 03:16:44 PST ---
(In reply to comment #16)
> Few small comments:
> 
> > Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1881
> > +    const int maxViewSideLength = std::max(viewSlicer.col2 - viewSlicer.col1 , viewSlicer.row2 - viewSlicer.row1);
> 
> Codint style: ' ,'. And line below this same. 
> 
I will fix the coding style.

> > Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1892
> > +        for (int i = 1; i < step * squareSide + 1; i++) {
> 
> "step * squareSide + 1" this could be moved outside the loop.
> 
why should it be outside the loop? what makes difference?

> > Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1919
> > +            if (static_cast<int>(viewSlicer.col1) < centerColumn
> 
> It may look better when these static_cast operations will be done once before this two ifs
To do so I have to assign the values to new values. Does it need?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.