[Webkit-unassigned] [Bug 73430] [EFL] Add pre-rendering implementation.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 22 21:42:09 PST 2011


--- Comment #14 from Ryuan Choi <ryuan.choi at samsung.com>  2011-12-22 21:42:09 PST ---
(From update of attachment 120430)
View in context: https://bugs.webkit.org/attachment.cgi?id=120430&action=review

> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:236
> +static inline void _ewk_view_tiled_rect_collision_resolve(int direction, int* destinationX, int* destinationY, int destinationWidth, int destinationHeight, int sourceX, int sourceY, int sourceWidth, int sourceHeight)

IMO, how about using IntRect or Eina_Rectangle for internal functions ?

IntRect is better for me.

> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:239
> +        *destinationX = *destinationX + (sourceX - *destinationX);

I don't know what you want, but it looks strange.
*destinationX will be sourceX.

In addition 1, 2, 4, 8 can be enumaration.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list