[Webkit-unassigned] [Bug 75156] [EFL] Add the Vibration API to the WebKit-EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75156





--- Comment #4 from Kihong Kwon <kihong.kwon at samsung.com>  2011-12-22 20:38:47 PST ---
(In reply to comment #3)
> (From update of attachment 120422 [details] [details])
> > Source/WebKit/efl/CMakeListsEfl.txt:135
> > +IF (ENABLE_VIBRATION)
> > +  LIST(APPEND WebKit_SOURCES
> > +    efl/WebCoreSupport/VibratorClientEfl.cpp
> > +    efl/ewk/ewk_vibrator.cpp
> > +  )
> > +ENDIF ()
> 
> If I am right, our CMake files use 4 spaces indentation without this file.
> 
> I'm not sure whether we need to fix this file because of history.
> If we need, I'll create a bug.
> 
> Anyway, I like that this patch follow our CMake indentation.
> 

If you make a bug for indentation problem about this file, It's good.
But, If I modify this from 2 spaces indentation to 4, It's ridiculous, because every other lines have 2 spaces indentation.
Is it no problem which is different between this patch and other lines in this file?

> > Source/WebKit/efl/WebCoreSupport/VibratorClientEfl.cpp:33
> > +{
> 
> how about adding ASSERT(m_view); ?
> 
> > Source/WebKit/efl/WebCoreSupport/VibratorClientEfl.h:20
> > +*/
> > +
> > +
> 
> IMO, one empty line is enough.
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:614
> > +#if ENABLE(VIBRATION)
> > +    pageClients.vibratorClient = new WebCore::VibratorClientEfl(smartData->self);
> 
> Who remove vibratorClient ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.