[Webkit-unassigned] [Bug 75156] [EFL] Add the Vibration API to the WebKit-EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75156


Tomasz Morawski <t.morawski at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.morawski at samsung.com




--- Comment #5 from Tomasz Morawski <t.morawski at samsung.com>  2011-12-22 23:56:03 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=120422&action=review

> ChangeLog:5
> +        http://dev.w3.org/2009/dap/vibration/

This line should be moved to new line. You could also add a short description about changes in the following files.

> Source/WebKit/efl/ChangeLog:5
> +        http://dev.w3.org/2009/dap/vibration/

This line could be moved to description section.

> Source/WebKit/efl/ChangeLog:14
> +

Missing some description about changes in the following files.

> Source/WebKit/efl/WebCoreSupport/VibratorClientEfl.cpp:36
> +VibratorClientEfl::~VibratorClientEfl()

What about moving this to header file (if you really need to have protected destructor)? Since it is an empty destructor?

> Source/WebKit/efl/WebCoreSupport/VibratorClientEfl.h:23
> +

This class should be inside of #if ENABLE(VIBRATION) block.

> Source/WebKit/efl/WebCoreSupport/VibratorClientEfl.h:41
> +

virtual keyword is missing. Anyway who and when is delete this object? Why this destructor is protected?

> Source/cmake/OptionsEfl.cmake:96
> +WEBKIT_FEATURE(ENABLE_VIBRATION "Enable vibration" DEFAULT ON)

I think this feature should be disabled by default. This is generic WebKit EFL profile that is mainly used on desktops.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.